Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorkQueue broken reference to rejectedWork and badWork #12204

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

amaltaro
Copy link
Contributor

Fixes #11681

Status

not-tested

Description

Because this is supposed to be a very simple (bug-)fix, so we better fix it sooner than later.

Ensure that rejectedWork and badWork are a known symbol before accessing them, such that we avoid errors like:

Error: local variable 'rejectedWork' referenced before assignment

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 9 warnings
    • 88 comments to review
  • Pycodestyle check: succeeded
    • 2 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/189/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro requested a review from vkuznet December 16, 2024 20:39
@amaltaro
Copy link
Contributor Author

Thank you for the prompt review, Valentin.

@amaltaro amaltaro merged commit 2af7de5 into dmwm:master Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global workqueue exception adding new work for ACDC workflows
3 participants