Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 11777: Adds two tests to UnstableTests #12206

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

d-ylee
Copy link
Contributor

@d-ylee d-ylee commented Dec 11, 2024

Fixes #11777

Status

ready

Description

Added the two unittests mentioned in #11777:

WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testThrottling changed from success to failure
WMCore_t.Services_t.Rucio_t.RucioUtils_t.RucioUtilsTest:testWeightedChoice changed from failure to success

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

N/A

External dependencies / deployment changes

N/A

@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 4 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/192/artifact/artifacts/PullRequestReport.html

@d-ylee
Copy link
Contributor Author

d-ylee commented Dec 11, 2024

test this please

@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/193/artifact/artifacts/PullRequestReport.html

@d-ylee d-ylee requested a review from amaltaro December 11, 2024 15:44
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks Dennis.

@amaltaro amaltaro merged commit 44d2a8a into dmwm:master Dec 11, 2024
3 checks passed
@d-ylee d-ylee deleted the fix-11777-add-unstable-tests branch December 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New unstable unit tests to be added to the list
3 participants