Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leading zeros to adler32 checksum to ensure 8 chars length - wma branch #9810

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Jul 8, 2020

wmagent branch version of #9809

Plus, a second fix to the RucioInjector, for cases where the file information has already been persisted in the database with an adler32 value that does not match this Rucio server regex:
'^[a-fA-F\\d]{8}$'

I tested some print-statement only in one of the production agents, and it seems to do the trick:

2020-07-08 17:59:12,790:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 37cc05 and new adler32 0037cc05
2020-07-08 17:59:12,790:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 499110dc and new adler32 499110dc
...
2020-07-08 17:59:12,805:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 995c1a90 and new adler32 995c1a90
2020-07-08 17:59:12,805:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 5e3a80 and new adler32 005e3a80
2020-07-08 17:59:12,805:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 61cdb8e1 and new adler32 61cdb8e1
2020-07-08 17:59:12,805:140568300840704:INFO:RucioInjectorPoller:AMR current adler32 655dc518 and new adler32 655dc518

@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 8, 2020

@todor-ivanov @nsmith- this is the patch I'm planning to push to the production agents. Please let me know if you see anything wrong with this, otherwise I will patch all of them tonight (CERN time).

@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 8, 2020

All the agents have been patched.

@amaltaro amaltaro merged commit d3eac15 into dmwm:1.3.3_wmagent Jul 8, 2020
@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 8, 2020

@nsmith-
Copy link

nsmith- commented Jul 9, 2020

Thanks for the quick patch!

@todor-ivanov
Copy link
Contributor

Hi @amaltaro I also tested this manually last night and the length of the result was exactly 8 chars. So I think it is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants