Add missing file and update README #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznet
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
The changes look fine to me but honestly I don't remember how setup was done. Said that, if you have executable on a node, you can still check them using strings /path/<your_executable> and compare the output with new executable, it will not be identical but close enough due to compiler differences. But, in any way, yes, we rely on custom exporters and yes I provided process_exporter, process_monitor.sh script, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating the
udp-collectorservice I have noticed that the repository is missing a few files.I have added them together with the links to the source code of the exporters (
process_exporterandnode_exporter), but I am not 100% sure that the exporters are the ones I linked since in our current infrastructure I can only see the compiled files.