wasi: address coverity warning

- add check for case when trying to provide a better Exception fails - the code was modified to avoid a CHECK_EQ in all cases in nodejs#31076, however, I believe that if we fail to create the exeption to throw instead of simply returning using a CHECK makes more sense. I think it should also address the coverity warning about not initializing in the constructor. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#49866 Reviewed-By: Colin Ihrig <[email protected]>
dnalborczyk · Oct 12, 2023 · c1a3a98 · c1a3a98
1 parent d398529
commit c1a3a98
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/node_wasi.cc b/src/node_wasi.cc
@@ -83,8 +83,8 @@ WASI::WASI(Environment* env,
   int err = uvwasi_init(&uvw_, options);
   if (err != UVWASI_ESUCCESS) {
     Local<Value> exception;
-    if (!WASIException(env->context(), err, "uvwasi_init").ToLocal(&exception))
-      return;
+    CHECK(
+        WASIException(env->context(), err, "uvwasi_init").ToLocal(&exception));
 
     env->isolate()->ThrowException(exception);
   }