feat(Field.Date): show error messages on invalid date #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joakbjerk
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
changed the title
joakbjerk
changed the title
4 tasks
joakbjerk
changed the title
joakbjerk
force-pushed
the
fix/datepicker-do-not-allow-invalid-date
branch
from
5541fe4 to
ae60a7d
Compare
joakbjerk
force-pushed
the
fix/datepicker-do-not-allow-invalid-date
branch
from
ae60a7d to
5859a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
We have decided to go for removing the strict input control, and allow for user to input invalid dates, and extending the
returnObjectto contain the invalid dates, so we can allow for error messaging when an invalid date is given. This is to make the component less confusing for users, and it will remove code complexity on our side.Field.Datewill be updated to show error messages by default when an invalid date is given, and invalid dates will be corrected to closes valid date, only whencorrectInvalidDatesis enabled.relies on groundwork from #4469
TODO
invalidDatepropertyDatePickerreturnObjectField.Date