Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#23] 내 방문기록 조회 API 추가 #26

Merged
merged 5 commits into from
Sep 1, 2024
Merged

[#23] 내 방문기록 조회 API 추가 #26

merged 5 commits into from
Sep 1, 2024

Conversation

youngreal
Copy link
Member

메모

토큰 검증 로직은 클라이언트에게 apple token을 받아 직접 apple oauth 서버와 통신 후 발급한 토큰으로 통신해야하는 관계로 추후 직접 토큰을 받아 테스트 해야합니다

* 현재 빌드 배포시 테스트 실행하지않고, 당장 필요하지않기에 disable
@youngreal youngreal added the enhancement New feature or request label Aug 28, 2024
@youngreal youngreal self-assigned this Aug 28, 2024
@youngreal youngreal linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link
Member

@min-0 min-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당
된다면 조만간 음성으로 방문기록 조회 플로우 따라 코드리뷰 한번 들어보고 싶어요!

* MemberAttraction 과 attraction 둘다 가지고있던 명소명을 Attraction에만 가지게끔 설계변경.

* 불필요하게 Wrapper 타입으로 설정되어있던 memberId 파라미터를 원시타입으로 변경
@youngreal youngreal merged commit 4a4acad into main Sep 1, 2024
1 check passed
@youngreal youngreal deleted the feat/#23 branch September 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

내 방문기록 보기 API 개발
2 participants