[#29] refresh token 재발급 API 추가 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
올려주신 링크가 로그인을 안하면 확인을 할 수가 없는 것 같은데, 이 아래 이미지와 같은건가용 ?
|
넵 그 이미지 맞습니다 편집권한은 구글로그인 해야될거에요 |
min-0
reviewed
Sep 2, 2024
Comment on lines
+40
to
+44
| //RTR | ||
| refreshTokenRepository.delete(refreshToken); | ||
| String newRefreshToken = jwtProvider.refreshToken(); | ||
| refreshTokenRepository.save(RefreshToken.of(refreshToken.getMemberId(), newRefreshToken)); | ||
| return new ReissueTokenResponse(jwtProvider.accessToken(refreshToken.getMemberId()), newRefreshToken); |
There was a problem hiding this comment.
Refresh Token Rotation전략이 해당 부분 리프레시 토큰 요청 시 기존 토큰을 폐기하고, 새 토큰을 클라이언트에 발급하는 것이군용
뭔가 간단한 논리인데 토큰 탈취를 막고 보안성을 높일 수 있다는 것이 신기함니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memo
https://www.mermaidchart.com/app/projects/635246a9-eda0-4690-b355-e904699dbd3b/diagrams/3ea2f5c4-36d2-4c53-9159-00d75dca8c11/version/v0.1/edit