#32 회원 탈퇴 api #37
Merged
#32 회원 탈퇴 api #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
애플 소셜로그인 탈퇴, 서버 내 유저 정보 삭제
Closed
2 tasks
|
쿼리파일들은 제가 수정한게 없는데 .......... 왜 같이 File Change가 되었는지 의문 ............... 입니다 ? |
min-0
commented
Sep 4, 2024
Comment on lines
+30
to
+32
| memberRepository.delete(member); | ||
| memberAttractionRepository.deleteById(memberId); | ||
| memberRegionRepository.deleteById(memberId); |
There was a problem hiding this comment.
여기서 유저가 올린 Photo도 같이 삭제해줘야 하는 거 맞나요오 ?
There was a problem hiding this comment.
제 생각엔 유저가 기록했던 정보들을 다른유저가 볼수있는 기능이 있지않는한 삭제하는게 맞다는 생각이 들지만
이건 민영님이 저보단 팀전체에게 요구사항을 구체화 하시는게 가장 좋을것같아요
예를들면 회원 탈퇴하면 방문기록도 삭제할까요? 등의 질문이요.
추가적으로, 회원탈퇴 시 해당 회원의 RefreshToken도 DB에서 제거가 필요해보여요
There was a problem hiding this comment.
오 네 알겠습니다 우선 refresh token부터 지울게요!
youngreal
reviewed
Sep 4, 2024
src/main/java/com/dnd/dndtravel/auth/controller/request/AppleRevokeRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/dndtravel/auth/controller/request/AppleRevokeRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/dndtravel/auth/controller/request/AppleWithdrawRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/dndtravel/auth/service/AppleOAuthService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/dndtravel/auth/controller/AuthController.java
Outdated
Show resolved
Hide resolved
Comment on lines
+30
to
+32
| memberRepository.delete(member); | ||
| memberAttractionRepository.deleteById(memberId); | ||
| memberRegionRepository.deleteById(memberId); |
There was a problem hiding this comment.
제 생각엔 유저가 기록했던 정보들을 다른유저가 볼수있는 기능이 있지않는한 삭제하는게 맞다는 생각이 들지만
이건 민영님이 저보단 팀전체에게 요구사항을 구체화 하시는게 가장 좋을것같아요
예를들면 회원 탈퇴하면 방문기록도 삭제할까요? 등의 질문이요.
추가적으로, 회원탈퇴 시 해당 회원의 RefreshToken도 DB에서 제거가 필요해보여요
youngreal
reviewed
Sep 4, 2024
src/main/java/com/dnd/dndtravel/auth/controller/AuthController.java
Outdated
Show resolved
Hide resolved
youngreal
reviewed
Sep 4, 2024
src/main/java/com/dnd/dndtravel/auth/controller/AuthController.java
Outdated
Show resolved
Hide resolved
youngreal
approved these changes
Sep 5, 2024
src/main/java/com/dnd/dndtravel/auth/controller/request/AppleWithdrawRequest.java
Outdated
Show resolved
Hide resolved
authorization code max:300
Closed
MemberService 충돌 해결
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
애플 소셜 로그인 탈퇴 및 서버 자체 회원 정보 삭제
Changes 📝
애플 소셜 로그인 탈퇴 과정
Screenshot 📷