Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 링크 공유 로직 변경 #128

Merged
merged 9 commits into from
Aug 19, 2023
Merged

fix: 링크 공유 로직 변경 #128

merged 9 commits into from
Aug 19, 2023

Conversation

corinthionia
Copy link
Member

@corinthionia corinthionia commented Aug 17, 2023

🔗 연관된 이슈 번호

resolve #127

✨ 어떤 기능을 개발했나요?

  • 링크 공유 바텀시트 새로 제작
  • 불필요한 라이브러리 제거 - react-copy-to-clipboard, react-spring-bottom-sheet
  • 링크 공유 로직 custom hook으로 추상화

✅ 어떻게 해결했나요?

기존에 만들어 둔 바텀시트 컴포넌트를 활용하려 했는데, 링크공유 바텀시트와 width/height, 폰트 크기, padding 값들이 전부 달라 그냥 새로 제작했습니다.

@corinthionia corinthionia self-assigned this Aug 17, 2023
@YesHyeon YesHyeon self-requested a review August 19, 2023 11:41
YesHyeon

This comment was marked as resolved.

@corinthionia corinthionia merged commit 9f2e3ee into develop Aug 19, 2023
@corinthionia corinthionia deleted the fix/eighth-qa branch August 19, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 링크 공유 로직 변경
2 participants