Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing changelog entries #87

Merged
merged 3 commits into from
Dec 21, 2023
Merged

fix missing changelog entries #87

merged 3 commits into from
Dec 21, 2023

Conversation

AGS4NO
Copy link
Contributor

@AGS4NO AGS4NO commented Dec 20, 2023

Changelog updates from github-changelog-generator have been overwriting the existing version since v3.3.0 due to missing tags in the release process.

  • Fixes changelog entries for versions >= 3.3.0

Tasks

  • Tag all previous release commits
    • git tag <tag-name> <commit-sha>
    • git push origin <tag-name>
  • Verify github-changelog-generator output
  • Verify commit, tag, and supermarket commands

@AGS4NO AGS4NO self-assigned this Dec 20, 2023
@AGS4NO AGS4NO marked this pull request as ready for review December 20, 2023 05:32
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a more human-centric changelog format that focuses on the important parts for the dependants' maintainers. Please check it out in the internal wiki.

@AGS4NO
Copy link
Contributor Author

AGS4NO commented Dec 20, 2023

We have a more human-centric changelog format that focuses on the important parts for the dependants' maintainers. Please check it out in the internal wiki.

I feel that this should be part of separate issue if we want to modify the format of the changelog:

  1. This change impacts all public cookbook releases (dnsimple and pdns)
  2. This moves an existing process which is automated to a manual one

Copy link
Member

@onlyhavecans onlyhavecans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur that this is addressing a fix in the current and changing the documented cookbook workflow is a separate policy change.

@DXTimer
Copy link
Contributor

DXTimer commented Dec 21, 2023

I concur that this is addressing a fix in the current and changing the documented cookbook workflow is a separate policy change.

I agree in which case a cookbook version bump should not happen as part of this PR.

@AGS4NO AGS4NO requested a review from DXTimer December 21, 2023 16:33
@AGS4NO
Copy link
Contributor Author

AGS4NO commented Dec 21, 2023

I agree in which case a cookbook version bump should not happen as part of this PR.

I removed the version change from this PR and will bump as part of a release commit after testing the fixes for change log generation.

@AGS4NO AGS4NO merged commit d08c881 into main Dec 21, 2023
14 checks passed
@AGS4NO AGS4NO deleted the fix/changelog-generation branch December 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants