Remove deprecated crypto APIs
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXTimer
approved these changes
Oct 7, 2024
m0rcq
approved these changes
Oct 8, 2024
We will need to update upstream e.g. |
weppos
reviewed
Oct 8, 2024
|
Since this is a library (and not a deployable artifact in itself) I'll merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of #36 and closes #38.
The issue was that
crypto:sign/5hashes the input before signing it. It's enough to pass innoneas the digest algorithm, and we get back the behavior ofcrypto:public_encrypt/4. The same goes for decrypting (withcrypto:verifynow).