-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Name of team plan #738
base: main
Are you sure you want to change the base?
Conversation
Thank you, @IchordeDionysos, for submitting these changes. Keeping the Enum values as they are makes sense, especially since we still have customers subscribed to the Professional plan (now considered legacy). @san983, everything looks good on my end. I do have a question about the fixtures—are they purely for illustrative purposes, or do we have tests or code that depend on the specific values defined in them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, pending @san983's review
LGTM too. AFAIS this is just illustrative. But you'd have to double check with anyone from the app team. |
@jacegu, I tagged you for a review to make sure the changes to the fixtures are OK and won't cause any issues if there’s code or tests relying on them (which I don't think we have, but I'm not 100% sure). Thanks! |
I did leave the enum value for the
Subscription
as it was...Not sure what the current status is here:
dnsimple-developer/content/v2/openapi.yml
Line 5050 in 3124e94
I actually also wasn't sure what to do with those
dnsimple-professional
plan ids.