Adds auto-merge + markdown & yaml linters #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
san983
added
the
enhancement
san983
force-pushed
the
task/revamp-ci
branch
from
54d69b9 to
1922910
Compare
san983
force-pushed
the
task/revamp-ci
branch
from
f83cf27 to
59ae7ec
Compare
weppos
reviewed
Jan 28, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
Where did you pick this template? It should be https://github.com/dnsimple/dnsimple-engineering/blob/main/templates/markdownlint.yaml
weppos
reviewed
Jan 28, 2025
| @@ -0,0 +1,10 @@ | |||
| --- | |||
|
@san983 please stop opening PRs with empty description. You must explain the intent, you can't just assume we know the reason (nor we will know it in the future). For instance, what is auto-merge for? Is it a feature we consistently apply to our product? Where is it documented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: