Support domain contact change #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the domain contact management with a new interface.
Users can now change a domain's contact via the
dnsimple_registered_resource.contact_idattribute. Once a change of contact ID is detected for a registered domain we will attempt to change the contact.Extended attributes for
dnsimple_registered_resourcecan now be edited at any time after the domain has been registered. The attributes are also used for contact change requests.This PR also re-introduces the
dnsimple_registrant_change_checkdata source, which can be used to see what would be the consequences and requirements of changing a domain's contact.This PR also comes with some fixes for boolean value comparisons in the
dnsimple_registered_domainresource.In addition the sweeper utility has been updated to carry out sweeps for registrant changes and also allow for registered domain cleanups.