Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update domain delegation name servers to a set #186

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Update domain delegation name servers to a set #186

merged 3 commits into from
Jan 24, 2024

Conversation

AGS4NO
Copy link
Contributor

@AGS4NO AGS4NO commented Jan 17, 2024 •
edited
Loading

Updates the domain delegation resource name servers attribute to a set.

This should prevent order errors and fix #159

@AGS4NO AGS4NO self-assigned this Jan 17, 2024
@AGS4NO AGS4NO marked this pull request as ready for review January 17, 2024 09:12
@AGS4NO AGS4NO requested a review from a team January 17, 2024 09:12
DXTimer
DXTimer approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I was able to verify the changes work as expected.

@weppos weppos changed the title update domain delegation name servers to a set Update domain delegation name servers to a set Jan 22, 2024
@AGS4NO AGS4NO merged commit bc71acb into main Jan 24, 2024
7 checks passed
@AGS4NO AGS4NO deleted the fix/domain-delegation-set branch January 24, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXTimer DXTimer DXTimer approved these changes

Assignees

@AGS4NO AGS4NO

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnsimple_domain_delegation name_servers should be a set, not a list
2 participants
@AGS4NO @DXTimer