feat: ✨ Suppression du clic sur le label et sur le message d'erreur du DsfrFileUpload #997
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,6 +51,7 @@ const acceptTypes = computed(() => { | |
| <label | ||
| class="fr-label" | ||
| :for="id" | ||
| @click.prevent | ||
| > | ||
| {{ label }} | ||
| <span | ||
|
|
@@ -79,6 +80,7 @@ const acceptTypes = computed(() => { | |
| v-if="error || validMessage" | ||
| class="fr-messages-group" | ||
| role="alert" | ||
| @click.prevent | ||
|
There was a problem hiding this comment. Voir commentaire précédent. There was a problem hiding this comment. Ici, en revanche, ce n’est pas normal que cela déclenche l’événement. Et ce n’est pas le cas dans l’exemple du Storybook : https://sb.vue-ds.fr/?path=/story/composants-dsfrfileupload--televersement-avec-erreur Je serait tenté de penser à une erreur d’imbrication de composant dans votre application. |
||
| > | ||
| <p | ||
| v-if="error" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ceci ne me semble pas accessible. Pourquoi tu penses que c’est souhaitable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est une remontée de bug chez nous. On voudrait que la fenêtre permettant de sélectionner le/les fichiers soit ouverte uniquement au click sur le input type file (le bouton parcourir). Actuellement la fenêtre s'ouvre aussi au click sur le label de l'input et au click sur le message d'erreur de l'input.
Quel problème cela pose pour l'accessibilité ? J'ai essayé la navigation au clavier et cela fonctionne toujours avec l'ajout des @click.prevent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peut être qu'on pourrait conditionner le click.prevent en fonction d'une nouvelle props ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne vois pas pourquoi ce serait considéré comme un bug. C’est une vraie feature. C’est bien prévu comme cela dans le DSFR, notamment parce que cliquer sur le bouton "parcourir" demande de la précision, et il est, pour certaines personnes, difficile de cliquer exactement sur le bouton parcourir. Je ne le rajouterai donc pas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK tu as raison, on laisse comme ça.