Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new haiku in bluewhale_cloud.md file #2944

Merged

Conversation

Gowtham-369
Copy link
Contributor

It adds my custom japanese haiku stored in bluewhale_cloud.md file

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this haiku! It looks like the file path isn't quite right — can you ensure that it is in the _haikus/ directory? Once you update the path we can merge this in.

Please note: maintainers will only go through one round of review, first reviews that are not sufficiently addressed will be closed and marked invalid. Also note that after more than two days of inactivity, pull requests are subject to being closed and marked invalid by maintainers.

@Gowtham-369
Copy link
Contributor Author

Hi @ltagliaferri, I corrected the path by moving the .md file to _haikus folder as requested. Please approve my PR. Thanks :)
Link to changes commit: 280c736

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this haiku and for contributing to open source 🎉

@ltagliaferri ltagliaferri merged commit 0d25216 into do-community:main Nov 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants