Fix template generation for WWW + Community #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Template generation
What issue does this relate to?
cc do-community/glob-tool#85
What should this PR do?
Fixes the logic used to clean up the DigitalOcean WWW/Community page for the tool template generation.
What are the acceptance criteria?
Running
npm run demo:devworks as expected, with the resulting tool having the DigitalOcean Community header/footer.Updating
npm run demo:initto callcd demo && WWW_TEMPLATE=true node ../src/cli.js template, and runningnpm run demo:dev, works as expected, with the resulting tool having the DigitalOcean WWW header/footer.Updating
npm run demo:initto callcd demo && BLANK_TEMPLATE=true node ../src/cli.js template, and runningnpm run demo:dev, works as expected, with the resulting tool having no header/footer.