Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PATCH method, flake8, star imports, etc. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PATCH method, flake8, star imports, etc. #31

wants to merge 1 commit into from

Conversation

cleberzavadniak
Copy link

This PR:

  • Adds a PATCH method on modelviews.DetailEndpoint;
  • Gets rid of star imports (from <module> import *);
  • Fixes indentation on parameters and arguments so the code passes on flake8;
  • Fixes the URL patterns declarations on testproject.

And I'm afraid it breaks compatibility with older versions of Django, since it's using "new style" URL patterns...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.39% when pulling 6e32bc3 on DroneMapp:patch-method-and-fixes into 47c1b00 on dobarkod:master.

@cleberzavadniak cleberzavadniak force-pushed the patch-method-and-fixes branch from 6e32bc3 to 858eb89 Compare April 9, 2017 15:54
@coveralls
Copy link

coveralls commented Apr 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 90.39% when pulling 858eb89 on DroneMapp:patch-method-and-fixes into 47c1b00 on dobarkod:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleberzavadniak @coveralls