Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to stop budification if an element already has dir attribute #10

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Add feature to stop budification if an element already has dir attribute #10

merged 3 commits into from
Jul 29, 2023

Conversation

ahangarha
Copy link
Member

@ahangarha ahangarha commented Jul 29, 2023 •
edited
Loading

By default, bidification stops if we reach an element with dir attribution (regardless of its value)

By passing greedy: true option, bidification disregards any possible existing dir attributes.

closes #3

@ahangarha ahangarha merged commit 402fbaa into main Jul 29, 2023
4 checks passed
@ahangarha ahangarha deleted the feature/add-greedy-option branch July 29, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop bidification when reached an element with explicit dir attribute
1 participant
@ahangarha