-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate more images to the new build system #78
Migrate more images to the new build system #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Draft…
@@ -5,34 +5,29 @@ def repos_anti_subset: | |||
[ | |||
# as we remove items from this list, we need to be careful that none of their *children* are still in the list | |||
# (which is why this is sorted in rough "build order" -- that means we can ~safely "pop" off the bottom) | |||
"clearlinux", | |||
"couchbase", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move these up?
"buildpack-deps", # direct children: erlang gcc golang haskell haxe influxdb kapacitor node openjdk perl pypy python rakudo-star ruby rust telegraf | ||
"couchbase", | ||
|
||
"debian", # direct children: aerospike buildpack-deps chronograf clojure couchdb dart emqx erlang haproxy haskell hitch httpd influxdb irssi julia maven memcached mono mysql neo4j neurodebian nginx node odoo openjdk perl php postgres pypy python r-base redis rethinkdb rocket.chat ruby rust spiped swipl unit varnish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an intent to the reordering?
The intent of the reorder is to make the dependencies a bit more clear |
110c666
to
04233f2
Compare
Because it was a little hard for me to follow what was moved around in $ jq -n -L . 'include "doi"; include "doi-new"; repos_anti_subset - new_repos_anti_subset'
[
"ubuntu",
"buildpack-deps",
"eclipse-temurin",
"haskell",
"liquibase",
"rakudo-star",
"silverpeas"
] So, these will be the additions to the new build system. This seems fine to me once you are ready. 👍 |
I've had a go at adding rakudo-star here anchore/syft#3224 |
@LaurentGoderre how close are you to getting this merged? We've got the next eclipse temurin release soon and were hoping to get a riscv64 image out which this PR should enable for us :) |
@gdams there should be a new version of Scout Indexer available soon so we can close the loop |
That would be great! Thanks so much |
Depends on: