Finally parse upstream releases data properly #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Dec 21, 2023
| @@ -50,9 +50,17 @@ RUN set -eux; \ | |||
| } >> /usr/local/etc/gemrc | |||
|
|
|||
| ENV LANG C.UTF-8 | |||
| {{ if .version | . == "3.0.6" or . == "3.1.4" or . == "3.2.2" then ( -}} | |||
There was a problem hiding this comment.
This was intentionally conservative to avoid churn in all the Dockerfiles for what amounts to entirely superficial changes.
This ports our `versions.sh` script to finally actually parse https://github.com/ruby/www.ruby-lang.org/raw/master/_data/releases.yml directly instead of scraping the data from the webpages generated from it. Additionally, this *should* allow us to automatically pick up GA releases after the pre-release (we can find out whether it worked next week!)
tianon
force-pushed
the
upstream-data
branch
from
53147bf to
25e8353
Compare
yosifkit
approved these changes
Dec 22, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 22, 2023
Changes: - docker-library/ruby@2b3b80b: Merge pull request docker-library/ruby#435 from infosiftr/upstream-data - docker-library/ruby@25e8353: Finally parse upstream releases data properly
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 22, 2023
Changes: - docker-library/ruby@088718f: Automate "latest" and "3" aliases - docker-library/ruby@2b3b80b: Merge pull request docker-library/ruby#435 from infosiftr/upstream-data - docker-library/ruby@25e8353: Finally parse upstream releases data properly
This was referenced Dec 22, 2023
Closed
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 26, 2023
Changes: - docker-library/ruby@8af6f23: Update 3.3-rc - docker-library/ruby@52e176c: Update 3.3 to 3.3.0, rust 1.74.1, rustup 1.26.0 - docker-library/ruby@04ee24d: Fix bug with 3.3.0 deleting 3.3 instead of 3.3-rc - docker-library/ruby@088718f: Automate "latest" and "3" aliases - docker-library/ruby@2b3b80b: Merge pull request docker-library/ruby#435 from infosiftr/upstream-data - docker-library/ruby@25e8353: Finally parse upstream releases data properly
|
It worked, and it's stable! 🥳 52e176c + 8af6f23 -> docker-library-bot/official-images@674e3b2 (in docker-library/official-images#15959) |
|
Thank you, @tianon! |
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/ruby@8af6f23: Update 3.3-rc - docker-library/ruby@52e176c: Update 3.3 to 3.3.0, rust 1.74.1, rustup 1.26.0 - docker-library/ruby@04ee24d: Fix bug with 3.3.0 deleting 3.3 instead of 3.3-rc - docker-library/ruby@088718f: Automate "latest" and "3" aliases - docker-library/ruby@2b3b80b: Merge pull request docker-library/ruby#435 from infosiftr/upstream-data - docker-library/ruby@25e8353: Finally parse upstream releases data properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports our
versions.shscript to finally actually parse https://github.com/ruby/www.ruby-lang.org/raw/master/_data/releases.yml directly instead of scraping the data from the webpages generated from it.Additionally, this should allow us to automatically pick up GA releases after the pre-release (we can find out whether it worked next week!)