[WIP] replace direct uses of logrus for containerd/log #5149
+133
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5149 +/- ##
==========================================
- Coverage 61.76% 61.33% -0.44%
==========================================
Files 297 294 -3
Lines 20768 20757 -11
==========================================
- Hits 12828 12731 -97
- Misses 7024 7108 +84
- Partials 916 918 +2 |
thaJeztah
force-pushed
the
cd8_logs
branch
3 times, most recently
from
23a6c37
to
95fbbbd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thaJeztah
force-pushed
the
cd8_logs
branch
3 times, most recently
from
d147de2
to
67e4aff
Compare
| @@ -278,7 +278,7 @@ | |||
| } | |||
|
|
|||
| func (w *stderrWriter) Write(p []byte) (int, error) { | |||
| logrus.Debugf("%s%s", w.debugPrefix, string(p)) | |||
| log.G(context.TODO()).Debug(w.debugPrefix + string(p)) | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)