Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/spf13/cobra v1.9.1 #5829

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 16, 2025

vendor: github.com/spf13/cobra v1.9.1

full diff: spf13/cobra@v1.8.1...v1.9.1

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.47%. Comparing base (61cd986) to head (9f19820).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5829   +/-   ##
=======================================
  Coverage   59.47%   59.47%           
=======================================
  Files         357      357           
  Lines       29744    29744           
=======================================
  Hits        17690    17690           
  Misses      11090    11090           
  Partials      964      964           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah changed the title [WIP] vendor: github.com/spf13/cobra main (v1.9.1) vendor: github.com/spf13/cobra v1.9.1 Feb 17, 2025
@thaJeztah thaJeztah self-assigned this Feb 17, 2025
@thaJeztah
Copy link
Member Author

FWIW; keeping this in draft, because docker/cli is a dependency of buildx, and I don't want to force it to update to latest cobra this late in the release; we can consider it for a minor release or next major release though.

@thaJeztah thaJeztah force-pushed the bump_cobra branch 2 times, most recently from 8dfc0e0 to 1a694f6 Compare March 21, 2025 16:15
@thaJeztah thaJeztah marked this pull request as ready for review March 21, 2025 16:16
@thaJeztah thaJeztah requested review from silvin-lubecki and a team as code owners March 21, 2025 16:16
Cobra now defines a CompletionFunc for the same, so we can alias
it to that, and stop using our own definition.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.3 milestone Mar 21, 2025
@thaJeztah thaJeztah merged commit ff5fdfa into docker:master Mar 21, 2025
87 checks passed
@thaJeztah thaJeztah deleted the bump_cobra branch March 21, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants