-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Add environment variable expansion for docker config plugin dirs #6487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add environment variable expansion for docker config plugin dirs #6487
Conversation
1759e72
to
d91b9d5
Compare
Hi @vvoland, any updates on this? |
f9717ab
to
c3326fd
Compare
LGTM after squashing commits |
I'm slightly on the fence; wondering; does the (for the example) The point here is that we don't to env-var expansion for any of the other paths, so this may now become a sliding slope where it needs to be added to every path that's in config; the |
In general the
Feel free to tell me about the option names / code files and I will have a look whether I can implement it for the additional options |
…gins/manager/manager.go` test: Add test for plugin directory environment variable expansion Signed-off-by: Paulchen <[email protected]>
c3326fd
to
da71a33
Compare
done 👍 |
- What I did
Closes #6486
- How I did it
- How to verify it
- Human readable description for the release notes
Add support to expand environment variables in docker plugin config directory string
- Add support to expand environment variables in docker plugin config directory string
I am really really new to Go like
0.5%
experience. The test is mainly assisted by Copilot with a bit of brain usage by my side. Feel free to help me to add like a negative test or something like that if the current one is not enough- A picture of a cute animal (not mandatory but encouraged)
