Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/moby/buildkit v0.17.1, github.com/docker/buildx v0.18.0 #12298

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

thaJeztah
Copy link
Member

go.mod: github.com/moby/buildkit v0.17.1

full diff: https://github.com/moby/buildkit/compare/v0.16.0..v0.17.1

go.mod: github.com/docker/buildx v0.18.0

full diff: https://github.com/docker/buildx/compare/v0.17.1..v0.18.0

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 15, 2024

Ah; looks like some breaking changes;

99.12 pkg/compose/build_buildkit.go:48:13: undefined: confutil.ConfigDir) (typecheck)
99.12 	"github.com/docker/compose/v2/pkg/compose"
99.12 	^
99.12 cmd/compose/compose.go:47:2: could not import github.com/docker/compose/v2/pkg/compose (-: # github.com/docker/compose/v2/pkg/compose
99.12 pkg/compose/build_buildkit.go:48:13: undefined: confutil.ConfigDir) (typecheck)
99.12 	"github.com/docker/compose/v2/pkg/compose"
99.12 	^
99.12 pkg/compose/attach.go:1: : # github.com/docker/compose/v2/pkg/compose [github.com/docker/compose/v2/pkg/compose.test]
99.12 pkg/compose/build_buildkit.go:48:13: undefined: confutil.ConfigDir (typecheck)

Looks to be related to docker/buildx@f89f861

@ndeloof ndeloof enabled auto-merge (rebase) November 15, 2024 10:48
confutil.ConfigDir(s.dockerCli),
confutil.NewConfig(s.dockerCli),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @crazy-max I think this is the right replacement, but just in case other changes are needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right!

@ndeloof ndeloof merged commit 61f1d4f into docker:main Nov 15, 2024
27 checks passed
@thaJeztah thaJeztah deleted the bump_buildx_buildkit branch November 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants