Skip to content

[testing] migrate to moby/moby/api, moby/moby/client modules (with current buildx) #13123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[testing] migrate to moby/moby/api, moby/moby/client modules (with current buildx) #13123

wants to merge 5 commits into from

Conversation

thaJeztah
Copy link
Member

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@thaJeztah thaJeztah requested a review from a team as a code owner July 31, 2025 16:15
@thaJeztah thaJeztah requested review from ndeloof and glours July 31, 2025 16:15
@thaJeztah thaJeztah marked this pull request as draft July 31, 2025 16:15
@thaJeztah thaJeztah changed the title Move modules no buildx [testing] migrate to moby/moby/api, moby/moby/client modules (with current buildx dev) Jul 31, 2025
@thaJeztah thaJeztah force-pushed the move_modules_no_buildx branch 5 times, most recently from 361225c to 85bf8e2 Compare July 31, 2025 17:15
@thaJeztah thaJeztah force-pushed the move_modules_no_buildx branch from 85bf8e2 to ec1eead Compare August 29, 2025 08:11
@thaJeztah thaJeztah changed the title [testing] migrate to moby/moby/api, moby/moby/client modules (with current buildx dev) [testing] migrate to moby/moby/api, moby/moby/client modules (with current buildx) Aug 29, 2025
@thaJeztah
Copy link
Member Author

thaJeztah commented Aug 29, 2025 •
edited
Loading

Right; this still fails;

/go/pkg/mod/github.com/docker/[email protected]/util/dockerutil/api.go:41:34:
cannot use dockerclient.WithTraceOptions(otelhttp.WithPropagators(propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{}))) (value of type "github.com/docker/docker/client".Opt)
as "github.com/moby/moby/client".Opt value in argument to append

/go/pkg/mod/github.com/docker/[email protected]/util/dockerutil/api.go:45:53:
cannot use clientOpts (variable of type []"github.com/moby/moby/client".Opt)
as []"github.com/docker/docker/client".Opt value in argument to dockerclient.NewClientWithOpts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof is a code owner automatically assigned from docker/compose-maintainers

@glours glours Awaiting requested review from glours glours is a code owner automatically assigned from docker/compose-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thaJeztah