[master] deb, rpm: slight refactor / cleanup #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "make dynbinary" target calls ./scripts/build/binary with the right options set, and does not use docker to build (so can be run as part of our deb/rpm build scripts. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The "-D" option creates parent directories if missing; we can use it in most places, except for one where we're using wildcards, as installing multiple files requires the target directory to exist. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This unlikely makes a big difference, as some files may have timestamps based on checkout date or being generated, but it doesn't hurt doing either. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This unlikely makes a big difference, as some files may have timestamps based on checkout date or being generated, but it doesn't hurt doing either. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Makes it slightly clearer where installing the CLI itself ends, and where installing completion scripts start. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The dh_bash-completion debhelper provides an easy way to install the shell-completion scripts for Bash. Unfortunately there is no stable equivalent yet for the other shells (zsh, fish, powershell), which resulted in two out of three shells requiring manual install. Given that the installation path for Bash is [well-documented][1], we can align Bash with the other shells to make this less confusing. This patch makes that change, and adds a code-comment to outline the reasoning (and possible future options) for future readers. [1]: https://github.com/scop/bash-completion/blob/79fd051907328c8c26372691f68d627c1f0e3916/README.md Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
build_cleanups
branch
from
7957839 to
f9f36d4
Compare
thaJeztah
changed the title
vvoland
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deb, rpm: use "make dynbinary" instead of ./scripts/build/binary
The "make dynbinary" target calls ./scripts/build/binary with the
right options set, and does not use docker to build (so can be
run as part of our deb/rpm build scripts.
rpm: use install -D where possible
The "-D" option creates parent directories if missing; we
can use it in most places, except for one where we're using
wildcards, as installing multiple files requires the target
directory to exist.
rpm: consistently use "install -p" (--preserve-timestamps)
This unlikely makes a big difference, as some files may have timestamps
based on checkout date or being generated, but it doesn't hurt doing
either.
deb: consistently use "install -p" (--preserve-timestamps)
This unlikely makes a big difference, as some files may have timestamps
based on checkout date or being generated, but it doesn't hurt doing
either.
deb: stop using dh_bash-completion for bash completions
The dh_bash-completion debhelper provides an easy way to install the
shell-completion scripts for Bash. Unfortunately there is no stable
equivalent yet for the other shells (zsh, fish, powershell), which
resulted in two out of three shells requiring manual install.
Given that the installation path for Bash is well-documented,
we can align Bash with the other shells to make this less confusing.
This patch makes that change, and adds a code-comment to outline
the reasoning (and possible future options) for future readers.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)