Makefile: switch to POSIX mode to handle errors #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from https://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html#tag_04_84_13_03 > .POSIX > > The application shall ensure that this special target is specified without prerequisites > or commands. If it appears as the first non-comment line in the makefile, make shall > process the makefile as specified by this section; otherwise, the behavior of make is > unspecified. Running the makefile with `.POSIX` runs shells with the `-e` options, which helps with handling errors; without this, make completes "succesfully", even shell commands in a target fail, for example: make[2]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-504/engine' mkdir -p build/linux/docker cp /home/ubuntu/workspace/docker-ce-packaging_PR-504/cli/build/docker build/linux/docker/ for f in dockerd containerd ctr containerd-shim containerd-shim-runc-v2 docker-init docker-proxy runc; do \ cp -L /home/ubuntu/workspace/docker-ce-packaging_PR-504/engine/bundles/binary-daemon/$f build/linux/docker/$f; \ done cp: cannot stat '/home/ubuntu/workspace/docker-ce-packaging_PR-504/engine/bundles/binary-daemon/containerd-shim-runc-v2': No such file or directory With this patch applied, the target succesfully detects the failure (changed one filename to be invalid for testing): make[1]: Entering directory '/docker/static' mkdir -p build/linux/docker cp /docker/src/github.com/docker/cli/build/docker build/linux/docker/ for f in dockerd containerd ctr containerd-shim containerd-shim-runc-v99 docker-init docker-proxy runc; do \ cp -L /docker/src/github.com/docker/docker/bundles/binary-daemon/$f build/linux/docker/$f; \ done cp: can't stat '/docker/src/github.com/docker/docker/bundles/binary-daemon/containerd-shim-runc-v99': No such file or directory make[1]: *** [Makefile:30: static-linux] Error 1 make[1]: Leaving directory '/docker/static' make: *** [Makefile:70: static] Error 2 Note that this patch does not change behavior on macOS, which runs an older version of GNU make, that does not support these options. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
relates to #504 (comment) |
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html#tag_04_84_13_03
Running the makefile with
.POSIXruns shells with the-eoptions, which helps withhandling errors; without this, make completes "succesfully", even shell commands in a
target fail, for example:
With this patch applied, the target succesfully detects the failure (changed one filename to be invalid for testing):
Note that this patch does not change behavior on macOS, which runs an older version of GNU make, that
does not support these options.