Skip to content

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jun 14, 2023

Proposed changes

  • desktop: update instruction for enabling wasm
  • desktop: rephrase wording used for the wasm integration

Related issues (optional)

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a878845
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/649da27411a1970008a5e1e8
😎 Deploy Preview https://deploy-preview-17545--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn added this to the DD 4.21 milestone Jun 14, 2023
@dvdksn dvdksn requested review from jprendes and rumpl June 14, 2023 14:02
@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 14, 2023
Copy link

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Jun 29, 2023
@dvdksn dvdksn marked this pull request as ready for review June 29, 2023 13:29
@dvdksn dvdksn requested a review from aevesdocker as a code owner June 29, 2023 13:29
aevesdocker
aevesdocker previously approved these changes Jun 29, 2023
@dvdksn dvdksn force-pushed the desktop/enable-wasm-setting branch 2 times, most recently from 5739d01 to 063a6f4 Compare June 29, 2023 14:00
aevesdocker
aevesdocker previously approved these changes Jun 29, 2023
Copy link

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@dvdksn dvdksn force-pushed the desktop/enable-wasm-setting branch 2 times, most recently from 6949281 to 421084a Compare June 29, 2023 14:28
aevesdocker
aevesdocker previously approved these changes Jun 29, 2023
Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn force-pushed the desktop/enable-wasm-setting branch from 421084a to a878845 Compare June 29, 2023 15:25
@dvdksn dvdksn requested a review from aevesdocker June 29, 2023 15:29
Copy link

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

We should fix the multi-service example in a follow up PR.

@aevesdocker aevesdocker merged commit 3c91e64 into docker:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants