Add info about host network support in DD 4.29 #19654

aheck · 2024-03-20T13:36:05Z

Description

Update the documentation to account for the new host networking feature in Docker Desktop.

Related issues or tickets

https://docker.atlassian.net/browse/POS-891

Reviews

@aevesdocker

Technical review
Editorial review
Product review

netlify · 2024-03-20T13:36:21Z

✅ Deploy Preview for docsdocker ready!

Name	Link
🔨 Latest commit	`810e6bf`
🔍 Latest deploy log	https://app.netlify.com/sites/docsdocker/deploys/66042760ef9fd00008c6c148
😎 Deploy Preview	https://deploy-preview-19654--docsdocker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dgageot · 2024-03-20T13:39:26Z

content/network/drivers/host.md

@@ -32,7 +32,8 @@ Host mode networking can be useful for the following use cases:
 This is because it doesn't require network address translation (NAT), and no "userland-proxy" is created for each port.

 The host networking driver only works on Linux hosts, and is not supported on
-Docker Desktop for Mac, Docker Desktop for Windows, or Docker EE for Windows Server.
+Docker EE for Windows Server but is available on newer versions of Docker
+Desktop as a paid beta feature (see below for details).


The working seems to say that users have to pay an additional cost for THIS feature.
If they are pro users, they get this feature "for free"

This is better said (IMHO) later in the doc

Good point, I removed the word "paid".

dgageot

LGTM with a nit

akerouanton · 2024-03-20T14:06:52Z

content/network/drivers/host.md

@@ -32,7 +32,8 @@ Host mode networking can be useful for the following use cases:
 This is because it doesn't require network address translation (NAT), and no "userland-proxy" is created for each port.

 The host networking driver only works on Linux hosts, and is not supported on


Can you remove the reference to Docker EE?

ctalledo

Looks good, just a few suggestions.

ctalledo · 2024-03-20T15:54:43Z

content/network/drivers/host.md

@@ -32,7 +32,8 @@ Host mode networking can be useful for the following use cases:
 This is because it doesn't require network address translation (NAT), and no "userland-proxy" is created for each port.

 The host networking driver only works on Linux hosts, and is not supported on
-Docker Desktop for Mac, Docker Desktop for Windows, or Docker EE for Windows Server.
+Docker EE for Windows Server but is available on newer versions of Docker


FYI, I don't believe there's Docker EE anymore.

ctalledo · 2024-03-20T15:56:03Z

content/network/drivers/host.md

+## Docker Desktop
+
+Since Docker Desktop 4.29 host networking is also supported
+on Docker Desktop for Mac, Docker Desktop for Windows, and Docker Desktop for


nit: Simplify to "Docker Desktop for Mac, Windows, and Linux as a beta feature ..."

ctalledo · 2024-03-20T15:57:29Z

content/network/drivers/host.md

+on Docker Desktop for Mac, Docker Desktop for Windows, and Docker Desktop for
+Linux as a beta feature for users with a paid subscription (Docker Pro or higher).
+
+This feature works in both directions. That means that you can


Suggestion: it would be really good to provide a simple example for host networking in each direction, so users can more easily grasp the concept and value of the feature. Maybe this belongs in the host-networking tutorial section though (I see a link to it under "Next Steps" below).

Thanks, good idea. I added examples.

Thanks, nice, simple examples.

ctalledo

LG, just one more comment.

ctalledo · 2024-03-22T19:20:12Z

content/network/drivers/host.md

+What you type in here will then appear on the terminal where the container is
+running.
+
+To access a service running on the container you can start a container with


To access a service running on the container

Did you mean "To access a service running on the host from the container, you can start ..."

ctalledo · 2024-03-22T19:21:30Z

content/network/drivers/host.md

+on Docker Desktop for Mac, Docker Desktop for Windows, and Docker Desktop for
+Linux as a beta feature for users with a paid subscription (Docker Pro or higher).
+
+This feature works in both directions. That means that you can


Thanks, nice, simple examples.

aevesdocker

Thanks @aheck. Just some style guide and formatting quibbles. Could also add the paid subscription info in a callout, but I'll do this in a follow-up PR after the release. No rush to do it now

content/network/drivers/host.md

Co-authored-by: Allie Sadler <[email protected]>

aevesdocker

Thanks @aheck LGTM

dvdksn

This PR doesn't contain all the necessary updates; there are more places referring to host networking with docker desktop, such as:

github-actions bot added the area/networking Relates to anything around networking label Mar 20, 2024

dgageot reviewed Mar 20, 2024

View reviewed changes

dgageot approved these changes Mar 20, 2024

View reviewed changes

aheck force-pushed the POS-2217 branch from a41453f to 1f9a301 Compare March 20, 2024 13:51

Add info about host network support in DD 4.29

270b54b

aheck force-pushed the POS-2217 branch from 1f9a301 to 270b54b Compare March 20, 2024 14:02

akerouanton reviewed Mar 20, 2024

View reviewed changes

ctalledo reviewed Mar 20, 2024

View reviewed changes

Review suggestions

7f5de8f

ctalledo approved these changes Mar 22, 2024

View reviewed changes

aevesdocker reviewed Mar 25, 2024

View reviewed changes

aevesdocker added this to the 4.29 milestone Mar 25, 2024

aheck and others added 2 commits March 26, 2024 11:13

Apply suggestions from code review

ef7b0cb

Co-authored-by: Allie Sadler <[email protected]>

Apply review suggestions

aa5389f

aevesdocker previously approved these changes Mar 26, 2024

View reviewed changes

Remove text saying that host networking is a paid feature

810e6bf

aheck dismissed aevesdocker’s stale review via 810e6bf March 27, 2024 14:04

aevesdocker approved these changes Apr 8, 2024

View reviewed changes

aevesdocker merged commit 64f176b into docker:main Apr 8, 2024

dvdksn reviewed Apr 8, 2024

View reviewed changes

dvdksn mentioned this pull request Apr 11, 2024

Add info that host networking has to be enabled #19781

Merged

3 tasks

		@@ -32,7 +32,8 @@ Host mode networking can be useful for the following use cases:
		This is because it doesn't require network address translation (NAT), and no "userland-proxy" is created for each port.

		The host networking driver only works on Linux hosts, and is not supported on

Add info about host network support in DD 4.29 #19654

Add info about host network support in DD 4.29 #19654

Uh oh!

Conversation

aheck commented Mar 20, 2024

Description

Related issues or tickets

Reviews

Uh oh!

netlify bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docsdocker ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgageot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ctalledo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ctalledo Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ctalledo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ctalledo Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aevesdocker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aevesdocker left a comment

Choose a reason for hiding this comment

Uh oh!

dvdksn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

netlify bot commented Mar 20, 2024 •

edited

Loading

ctalledo Mar 22, 2024 •

edited

Loading

ctalledo Mar 22, 2024 •

edited

Loading