Skip to content

Conversation

glours
Copy link
Contributor

@glours glours commented Mar 27, 2024

Description

Add definitions for the 2 new env variables added in Compose v2.26.0 : COMPOSE_MENU and COMPOSE_EXPERIMENTAL

Reviews

  • Technical review
  • Editorial review
  • Product review

@glours glours requested a review from aevesdocker as a code owner March 27, 2024 09:20
@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Mar 27, 2024
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit ed233b8
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6603ea037b03e900083a1663
😎 Deploy Preview https://deploy-preview-19695--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@glours glours requested review from ndeloof, milas and jhrotko March 27, 2024 09:21
@aevesdocker aevesdocker added this to the 4.29 milestone Mar 27, 2024
@glours glours force-pushed the add-new-compose-env-variables branch from 7b9d0b1 to 951a335 Compare March 27, 2024 09:28
@glours glours force-pushed the add-new-compose-env-variables branch from 951a335 to b482c96 Compare March 27, 2024 09:29
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @glours

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


### COMPOSE\_MENU

When enabled, Compose displays a navigation menu where you can choose to open the Compose stack in Docker Desktop, switch on [`watch` mode](../file-watch.md), or use [Docker Debug](../../reference/cli/docker/debug.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When enabled, Compose displays a navigation menu where you can choose to open the Compose stack in Docker Desktop, switch on [`watch` mode](../file-watch.md), or use [Docker Debug](../../reference/cli/docker/debug.md).
When enabled, Compose displays a navigation menu where you can choose to open the Compose stack in Docker Desktop, switch on [`watch` mode](../file-watch.md), and more.

There's no Docker Debug integration right now/yet - maybe just go generic?


> **Note**
>
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later.

(Allie can keep me honest, but I'm pretty sure we always end with punctuation)


> **Note**
>
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later
> Available in Docker Compose version 2.26.0 and later, and Docker Desktop version 4.29 and later.

@aevesdocker aevesdocker merged commit e1414ca into docker:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants