Skip to content

Conversation

Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented Jan 24, 2025

Description

Add a language-specific guide for Deno.

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 62f8262
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67ae3c44abb21d0008524cb9
😎 Deploy Preview https://deploy-preview-21893--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pradumnasaraf
Copy link
Contributor Author

Hey @dvdksn,

You can fork the repo https://github.com/Pradumnasaraf/deno-docker to the dockersamples. I have mentioned the URL is the docs!

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pradumnasaraf. Overall looks good to me. Left some grammar nits and the Kubernetes port config didn't work.
I'm working on getting the sample repo forked to dockersamples as I don't have permission in that org. I'll update here when it's forked.

@Pradumnasaraf
Copy link
Contributor Author

Hey,

Thanks for the review, @craig-osterhout. I have updated the the PR.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There are some vale vocab nits that I'll follow up with.

@craig-osterhout craig-osterhout merged commit ebb2fe4 into docker:main Feb 13, 2025
13 of 14 checks passed
@Pradumnasaraf
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants