Skip to content

Conversation

aevesdocker
Copy link
Contributor

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b8cca14
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67e6b94cd49e140008c4e981
😎 Deploy Preview https://deploy-preview-22296--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review March 24, 2025 15:59
@aevesdocker aevesdocker added this to the 4.40 milestone Mar 24, 2025
Copy link

@francesco-corti francesco-corti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.
I'm suggesting to use the final namesspace and model name that users will find in Hub.

Example:

```console
$ docker model pull ignaciolopezluna020/llama3.2:1b

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to replace this with "ai/".
I perfectly understand why this is not done yet (we are publishing the models now in the "ai" namespace) but for the final release, we want to use the final namespace.
CC @aevesdocker


```text
Downloaded: 626.05 MB
Model ignaciolopezluna020/llama3.2:1b pulled successfully

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

#### One-time prompt

```console
$ docker model run ignaciolopezluna020/llama3.2:1b "Hi"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

#### Interactive chat

```console
docker model run ignaciolopezluna020/llama3.2:1b

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

1. Pull the required model from Docker Hub so it's ready for use in your app.

```console
$ docker model pull ignaciolopezluna020/llama3.2:1b

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

curl http://model-runner.docker.internal/engines/llama.cpp/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{
"model": "ignaciolopezluna020/llama3.2:1b",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

localhost/exp/vDD4.40/engines/llama.cpp/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{
"model": "ignaciolopezluna020/llama3.2:1b",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

curl http://localhost:8080/engines/llama.cpp/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{
"model": "ignaciolopezluna020/llama3.2:1b",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: I think we want to replace this with "ai/".

Copy link

@francesco-corti francesco-corti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker model list is changed.

@aevesdocker aevesdocker requested a review from a team March 26, 2025 16:05
Docker Model Runner:
availability: Beta
requires: Docker Desktop 4.40 and later
for: Docker Desktop for Mac with Apple Silicon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add another line for the summary bar? or the ability to populate the "Admin" symbol only if a keyword is there? it looks a little wonky in the summary bar with the Admin shield icon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I can help with this if you'd like me to add this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the bandwidth @sarahsanders-docker, that'd be so helpful, thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I can spin this up quick!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, looks good! I left one comment about the summary bar, let me know if you'd like me to open a PR to fix the icon rendering/support alternative text in that field

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aevesdocker aevesdocker merged commit c563d87 into docker:main Mar 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants