-
Notifications
You must be signed in to change notification settings - Fork 8k
Engdocs 2499 #22296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engdocs 2499 #22296
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
I'm suggesting to use the final namesspace and model name that users will find in Hub.
Example: | ||
|
||
```console | ||
$ docker model pull ignaciolopezluna020/llama3.2:1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to replace this with "ai/".
I perfectly understand why this is not done yet (we are publishing the models now in the "ai" namespace) but for the final release, we want to use the final namespace.
CC @aevesdocker
|
||
```text | ||
Downloaded: 626.05 MB | ||
Model ignaciolopezluna020/llama3.2:1b pulled successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
#### One-time prompt | ||
|
||
```console | ||
$ docker model run ignaciolopezluna020/llama3.2:1b "Hi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
#### Interactive chat | ||
|
||
```console | ||
docker model run ignaciolopezluna020/llama3.2:1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
1. Pull the required model from Docker Hub so it's ready for use in your app. | ||
|
||
```console | ||
$ docker model pull ignaciolopezluna020/llama3.2:1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
curl http://model-runner.docker.internal/engines/llama.cpp/v1/chat/completions \ | ||
-H "Content-Type: application/json" \ | ||
-d '{ | ||
"model": "ignaciolopezluna020/llama3.2:1b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
localhost/exp/vDD4.40/engines/llama.cpp/v1/chat/completions \ | ||
-H "Content-Type: application/json" \ | ||
-d '{ | ||
"model": "ignaciolopezluna020/llama3.2:1b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
curl http://localhost:8080/engines/llama.cpp/v1/chat/completions \ | ||
-H "Content-Type: application/json" \ | ||
-d '{ | ||
"model": "ignaciolopezluna020/llama3.2:1b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: I think we want to replace this with "ai/".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker model list is changed.
Docker Model Runner: | ||
availability: Beta | ||
requires: Docker Desktop 4.40 and later | ||
for: Docker Desktop for Mac with Apple Silicon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add another line for the summary bar? or the ability to populate the "Admin" symbol only if a keyword is there? it looks a little wonky in the summary bar with the Admin shield icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I can help with this if you'd like me to add this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the bandwidth @sarahsanders-docker, that'd be so helpful, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I can spin this up quick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, looks good! I left one comment about the summary bar, let me know if you'd like me to open a PR to fix the icon rendering/support alternative text in that field
fd21824
to
b8cca14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related issues or tickets
Reviews