This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Fix for #2989 #4770
Open
Fix for #2989 #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "patch-2" [email protected]:olivbour/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String". That's because of this error that isHypervAdministrator() always return false and and consequently "Administrator" role is requested. Signed-off-by: Olivier Bourgeat <[email protected]>
|
Hello, We are really waiting for a fix on this issue (giving everybody in the company administrator rights is not possible). Since the fix has already been coded, thanks to @olivbour, how much time will it take to see this in docker desktop ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user member of "Hyper-V Administrators" group should be able to create a VM without also being member of "Administrators" group.
For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String".
That's because of this error that isHypervAdministrator() always return false and and consequently "Administrator" role is requested.
Related issue(s)
#2989