Skip to content

Remove feature flag telemetry #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Remove feature flag telemetry #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,7 @@ const activateDockerLSP = async (ctx: vscode.ExtensionContext) => {

export function activate(ctx: vscode.ExtensionContext) {
extensionVersion = String(ctx.extension.packageJSON.version);

const configValue = vscode.workspace
.getConfiguration('docker.extension.experimental.release')
.get<string>('march2025');
recordVersionTelemetry(configValue, 'force');
recordVersionTelemetry();
activateExtension(ctx);
}

Expand Down Expand Up @@ -181,10 +177,7 @@ function listenForConfigurationChanges(ctx: vscode.ExtensionContext) {
);
}

function recordVersionTelemetry(
featureFlag: string | undefined,
featureFlagValue: string,
) {
function recordVersionTelemetry() {
let versionString: string | null = null;
const process = spawn('docker', ['-v']);
process.stdout.on('data', (data) => {
Expand All @@ -197,23 +190,17 @@ function recordVersionTelemetry(
// this happens if docker cannot be found on the PATH
queueTelemetryEvent('client_heartbeat', false, {
docker_version: 'spawn docker -v failed',
feature_flag: featureFlag,
feature_flag_value: featureFlagValue,
});
publishTelemetry();
});
process.on('exit', (code) => {
if (code === 0) {
queueTelemetryEvent('client_heartbeat', false, {
docker_version: String(versionString),
feature_flag: featureFlag,
feature_flag_value: featureFlagValue,
});
} else {
queueTelemetryEvent('client_heartbeat', false, {
docker_version: String(code),
feature_flag: featureFlag,
feature_flag_value: featureFlagValue,
});
}
publishTelemetry();
Expand Down
Loading