Merge branch 'develop-php7' into master-php7

# Conflicts:
#	Dockerfile
#	startup.sh

Dockerfile

@@ -57,12 +57,14 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && \
     rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 
 RUN \
-    # Create a non-root user with access to sudo and the default group set to 'users' (gid = 100)
-    useradd -m -s /bin/bash -g users -G sudo -p docker docker && \
+    # Create a non-root "docker" user (uid = 1000) with access to sudo and the default group set to 'users' (gid = 100)
+    useradd -m -s /bin/bash -u 1000 -g users -G sudo -p docker docker && \
     echo 'docker ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
 
-# Install gosu and give access to the users group to use it. gosu will be used to run services as a different user.
-RUN curl -sSL "https://github.com/tianon/gosu/releases/download/1.7/gosu-$(dpkg --print-architecture)" -o /usr/local/bin/gosu && \
+# Install gosu and give access to the users group to use it.
+# gosu is used instead of sudo to start the main container process (pid 1) in a docker friendly way.
+# https://github.com/tianon/gosu
+RUN curl -sSL "https://github.com/tianon/gosu/releases/download/1.10/gosu-$(dpkg --print-architecture)" -o /usr/local/bin/gosu && \
     chown root:users /usr/local/bin/gosu && \
     chmod +sx /usr/local/bin/gosu
 
@@ -147,7 +149,7 @@ RUN mkdir -p /var/www/docroot && \
     sed -i '/blackfire.agent_socket = /c blackfire.agent_socket = tcp://blackfire:8707' /etc/php/7.0/mods-available/blackfire.ini && \
     # Disable xdebug by default. We will enabled it at startup (see startup.sh)
     phpdismod xdebug && \
-    # Create symlinks to project level overrides
+    # Create symlinks to project level overrides (if the source files are missing, nothing will break)
     ln -s /var/www/.docksal/etc/php/php.ini /etc/php/7.0/fpm/conf.d/99-overrides.ini && \
     ln -s /var/www/.docksal/etc/php/php-cli.ini /etc/php/7.0/cli/conf.d/99-overrides.ini
 
@@ -170,12 +172,12 @@ RUN gem install bundler
 # Home directory for bundle installs
 ENV BUNDLE_PATH .bundler
 
-ENV COMPOSER_VERSION 1.3.0
-ENV DRUSH_VERSION 8.1.10
-ENV DRUPAL_CONSOLE_VERSION 1.0.0-rc16
-ENV MHSENDMAIL_VERSION 0.2.0
-ENV WPCLI_VERSION 1.1.0
-ENV MG_CODEGEN_VERSION 1.4
+ENV COMPOSER_VERSION=1.3.0 \
+	DRUSH_VERSION=8.1.10 \
+	DRUPAL_CONSOLE_VERSION=1.0.0-rc16 \
+	MHSENDMAIL_VERSION=0.2.0 \
+	WPCLI_VERSION=1.1.0 \
+	MG_CODEGEN_VERSION=1.4
 RUN \
     # Composer
     curl -sSL "https://github.com/composer/composer/releases/download/${COMPOSER_VERSION}/composer.phar" -o /usr/local/bin/composer && \
@@ -206,9 +208,9 @@ RUN git clone --recursive https://github.com/sorin-ionescu/prezto.git "${ZDOTDIR
     ln -s $HOME/.zprezto/runcoms/zshrc $HOME/.zshrc
 
 # Install nvm and a default node version
-ENV NVM_VERSION 0.33.0
-ENV NODE_VERSION 6.10.0
-ENV NVM_DIR $HOME/.nvm
+ENV NVM_VERSION=0.33.0 \
+	NODE_VERSION=6.10.0 \
+	NVM_DIR=$HOME/.nvm
 RUN \
     curl -sSL https://raw.githubusercontent.com/creationix/nvm/v${NVM_VERSION}/install.sh | bash && \
     . $NVM_DIR/nvm.sh && \
@@ -217,7 +219,9 @@ RUN \
     # Install global node packages
     npm install -g npm && \
     npm install -g yarn && \
-    npm install -g bower
+    npm install -g bower && \
+	# Fix npm complaining about permissions and not being able to update
+	sudo rm -rf $HOME/.config
 
 ENV PATH $PATH:$HOME/.composer/vendor/bin
 RUN \
@@ -243,26 +247,34 @@ COPY config/.ssh $HOME/.ssh
 COPY config/.drush $HOME/.drush
 COPY config/.zpreztorc $HOME/.zpreztorc
 COPY config/.docksalrc $HOME/.docksalrc
+# Fix permissions after copy
+RUN sudo chown -R $(id -u docker):$(id -g docker) $HOME
+
 COPY config/supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 COPY startup.sh /opt/startup.sh
 
-# Fix permissions after COPY
-RUN sudo chown -R docker:users $HOME
-
 EXPOSE 9000
 EXPOSE 22
 
 WORKDIR /var/www
 
-# Default SSH key name
-ENV SSH_KEY_NAME id_rsa
-# ssh-agent proxy socket (requires docksal/ssh-agent)
-ENV SSH_AUTH_SOCK /.ssh-agent/proxy-socket
-# Set TERM so text editors/etc. can be used
-ENV TERM xterm
+ENV \
+	# Default SSH key name
+	SSH_KEY_NAME=id_rsa \
+	# ssh-agent proxy socket (requires docksal/ssh-agent)
+	SSH_AUTH_SOCK=/.ssh-agent/proxy-socket \
+	# Set TERM so text editors/etc. can be used
+	TERM=xterm \
+	# Allow PROJECT_ROOT to be universally used in fin custom commands (inside and outside cli)
+	PROJECT_ROOT=/var/www \
+	# Allow matching host uid:gid
+	HOST_UID=1000 \
+	HOST_GID=100
+
+USER root
 
 # Starter script
 ENTRYPOINT ["/opt/startup.sh"]
 
 # By default, launch supervisord to keep the container running.
-CMD ["gosu", "root", "supervisord"]
+CMD ["supervisord"]

startup.sh

@@ -1,14 +1,24 @@
 #!/bin/bash
 
+HOME_DIR='/home/docker'
+
+DEBUG=${DEBUG:-0}
+# Turn debugging ON when cli is started in the service mode
+[[ "$1" == "supervisord" ]] && DEBUG=1
+echo-debug ()
+{
+	[[ "$DEBUG" != 0 ]] && echo "$@"
+}
+
 # Copy Acquia Cloud API credentials
 # @param $1 path to the home directory (parent of the .acquia directory)
 copy_dot_acquia ()
 {
   local path="${1}/.acquia/cloudapi.conf"
   if [[ -f ${path} ]]; then
-    echo "Copying Acquia Cloud API settings in ${path} from host..."
-    mkdir -p ~/.acquia
-    cp ${path} ~/.acquia
+    echo-debug "Copying Acquia Cloud API settings in ${path} from host..."
+    mkdir -p ${HOME_DIR}/.acquia
+    cp ${path} ${HOME_DIR}/.acquia
   fi
 }
 
@@ -18,19 +28,26 @@ copy_dot_drush ()
 {
   local path="${1}/.drush"
   if [[ -d ${path} ]]; then
-    echo "Copying Drush settigns in ${path} from host..."
-    cp -r ${path} ~
+    echo-debug "Copying Drush settigns in ${path} from host..."
+    cp -r ${path} ${HOME_DIR}
   fi
 }
 
-# Copy Acquia Cloud API credentials from host if available
+# Copy Acquia Cloud API credentials and Drush settings from host if available
 copy_dot_acquia '/.home' # Generic
-
-# Copy Drush settings from host if available
 copy_dot_drush '/.home' # Generic
 
-# Reset home directory ownership
-sudo chown $(id -u):$(id -g) -R ~
+## Docker user uid/gid mapping to the host user uid/gid
+if [[ "$HOST_UID" != "" ]] && [[ "$HOST_GID" != "" ]]; then
+	if [[ "$HOST_UID" != "$(id -u docker)" ]] || [[ "$HOST_GID" != "$(id -g docker)" ]]; then
+		echo-debug "Updating docker user uid/gid to $HOST_UID/$HOST_GID to match the host user uid/gid..."
+		sudo usermod -u "$HOST_UID" -o docker >/dev/null 2>&1
+		sudo groupmod -g "$HOST_GID" -o users >/dev/null 2>&1
+		# Make sure permissions are correct after the uid/gid change
+		sudo chown "$HOST_UID:$HOST_GID" -R ${HOME_DIR}
+		sudo chown "$HOST_UID:$HOST_GID" /var/www
+	fi
+fi
 
 # Enable xdebug
 if [[ "${XDEBUG_ENABLED}" == "1" ]]; then
@@ -39,4 +56,10 @@ if [[ "${XDEBUG_ENABLED}" == "1" ]]; then
 fi
 
 # Execute passed CMD arguments
-exec "$@"
+# Service mode (run as root)
+if [[ "$1" == "supervisord" ]]; then
+	gosu root supervisord
+# Command mode (run as docker user)
+else
+	gosu docker "$@"
+fi