Skip to content

fix(document): save document images page by page #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ClemDoum
Copy link
Contributor

@ClemDoum ClemDoum commented Apr 1, 2025

Bug description

fixes: #179

When saving a markdown page by page (potentially to keep track of page size in characters for instance) images of the whole documents were save. This had 2 majors drawbacks:

  • saving too many images when we want to dump a single page
  • saving all images, n times for a n pages doc when saving it page by page

Fix

Changed

  • updated DoclingDocument._with_pictures_refs to take the page_no and forward it to iter_items()

Copy link

mergify bot commented Apr 1, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@ClemDoum ClemDoum force-pushed the fix(document)/picture-refs branch from e3a50f7 to 9022b61 Compare April 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant