feat: Google Docs, Files, PDF URLs, Spreadsheets, Presentations to EXPORT URL #320
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
vtempest
changed the title
docling_core/utils/file.py
Outdated
| ) | ||
| elif doc_type == "presentation": | ||
| http_url = TypeAdapter(AnyHttpUrl).validate_python( | ||
| f"https://docs.google.com/presentation/d/{doc_id}/export/pptx" |
There was a problem hiding this comment.
is this different on purpose or just a copy&paste typo?
There was a problem hiding this comment.
I pushed a new PR and closed old one since it has the old code. Let me know if typo needs to be fixed
There was a problem hiding this comment.
I'm actually wondering if it shouldn't be like this
| f"https://docs.google.com/presentation/d/{doc_id}/export/pptx" | |
| f"https://docs.google.com/presentation/d/{doc_id}/export?format=pptx" |
There was a problem hiding this comment.
Both ways have been tested to work
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@vtempest it seems your commits are not yet signed-off. Can you please follow the steps in https://github.com/docling-project/docling-core/pull/320/checks?check_run_id=43652326093? |
Will someone write unit tests for codecov? Or where to add them? |
|
should this be in a separate file like called url-to-doc-adapters.py which should handle google docs, dropbox, scribr etc |
Signed-off-by: vtempest <[email protected]>
vtempest
force-pushed
the
main
branch
2 times, most recently
from
2b5bf24 to
1321794
Compare
This is checking the overall tests in the repo. But in this case I don't really know if we can easily make tests. Maybe with some public readable links. |
Google Docs, Files, PDF URLs, Spreadsheets, Presentations to EXPORT URL