Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alwaysScrollHeader option #1963

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

naneko
Copy link

@naneko naneko commented Jan 9, 2023

Summary

In Firefox, the browser's auto-restore scroll position feature doesn't work correctly when navigating via history. I have not tried it in other browsers. I added this feature for myself but I figured I should contribute it in case someone finds it useful, and since is a very small change.

What kind of change does this PR introduce?

  • Feature
  • Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 2:58AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94f7fbf:

Sandbox Source
docsify-template Configuration

@naneko naneko marked this pull request as ready for review March 10, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant