Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: render code style clean and update #2477

Merged
merged 9 commits into from
Sep 12, 2024
Merged

chore: render code style clean and update #2477

merged 9 commits into from
Sep 12, 2024

Conversation

Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Jul 30, 2024 •
edited
Loading

Summary

Clean and make the compiler.js slimmer to main core compile logic, remove unnecessary code.

Changes:

  • Move heading compiler to separate file like other renderer customizers.
  • Move compileMedia as individual file also.
  • Move the _renderTo to dom utils method.
  • Remove the unused headline.js file.

Related issue, if any:

What kind of change does this PR introduce?

Code style update

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

Yes

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 7:33am

@Koooooo-7 Koooooo-7 marked this pull request as ready for review July 30, 2024 11:38
@Koooooo-7 Koooooo-7 requested review from jhildenbiddle, trusktr, sy-records and a team July 30, 2024 11:39
trusktr
trusktr requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always great to keep making code org better!

src/core/render/compiler.js Outdated Show resolved Hide resolved
src/core/render/compiler/headling.js Outdated Show resolved Hide resolved
src/core/util/dom.js Outdated Show resolved Hide resolved
@Koooooo-7 Koooooo-7 requested a review from trusktr August 14, 2024 15:30
@Koooooo-7
Copy link
Member Author

--- Hi @trusktr Joe, thx for the review, already updated, PTAL.

@Koooooo-7 Koooooo-7 merged commit 5f80683 into develop Sep 12, 2024
9 checks passed
@Koooooo-7 Koooooo-7 deleted the chore-render-clean branch September 12, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trusktr trusktr trusktr approved these changes

@jhildenbiddle jhildenbiddle Awaiting requested review from jhildenbiddle

@sy-records sy-records Awaiting requested review from sy-records

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koooooo-7 @trusktr