New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add/remove_index detail in README #153

Open

henrahmagix wants to merge 1 commit into doctolib:master from henrahmagix:patch-1

henrahmagix commented Feb 21, 2025

Both add_index and remove_index use without_timeout(&), so they don't set a lock timeout of 30 seconds =)

See

safe-pg-migrations/lib/safe-pg-migrations/plugins/statement_insurer.rb

Line 64 in b0efa6d

without_timeout { super(table_name, column_name, **options) }

and

safe-pg-migrations/lib/safe-pg-migrations/plugins/statement_insurer.rb

Line 71 in b0efa6d

without_timeout { super(table_name, column_name, **options) }


          Fix add/remove_index detail in README

6fe4542

Both `add_index` and `remove_index` use `without_timeout(&)`, so they don't set a lock timeout of 30 seconds =)

See https://github.com/doctolib/safe-pg-migrations/blob/b0efa6d52d304f22eb9fdba5e94448c3bde00467/lib/safe-pg-migrations/plugins/statement_insurer.rb#L64 and https://github.com/doctolib/safe-pg-migrations/blob/b0efa6d52d304f22eb9fdba5e94448c3bde00467/lib/safe-pg-migrations/plugins/statement_insurer.rb#L71

henrahmagix requested a review from a team as a code owner

February 21, 2025 18:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet