Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony docs #2667

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Update Symfony docs #2667

merged 1 commit into from
Aug 14, 2023

Conversation

franmomu
Copy link
Collaborator

@franmomu franmomu commented Aug 14, 2023

Based on what @DubbleClick did in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2639/files#diff-531b03ac1e9de5d271d400acc8d449fa4f5a7d68d3a1469d3ac8c00119925c61

Better to have this in a separated PR, I think we can remove the reference to the Symfony version, doctrine event listeners will work in versions of symfony < 6.3, if there are differences between versions we can add a section in the same document.

I've updated a bit the code to add types and also use attribute mapping instead of annotation by default.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef277c9) 79.22% compared to head (f14a612) 79.22%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2667   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files         161      161           
  Lines        8415     8415           
=======================================
  Hits         6667     6667           
  Misses       1748     1748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys phansys merged commit 4fd6a62 into doctrine-extensions:main Aug 14, 2023
20 checks passed
@phansys
Copy link
Collaborator

phansys commented Aug 14, 2023

Thank you @franmomu!

@franmomu franmomu deleted the update_doc branch August 15, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants