Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Casting issue due to MariaDB not included in inheritance schema anymore #2888

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Pixelshaped
Copy link
Contributor

Hi there!

Fixes #2887

@Pixelshaped Pixelshaped marked this pull request as draft October 14, 2024 12:39
@Pixelshaped
Copy link
Contributor Author

Converting to draft as I have to make sure this still works with DBAL3

@Pixelshaped Pixelshaped marked this pull request as ready for review October 14, 2024 12:53
@Pixelshaped
Copy link
Contributor Author

Yes it still works (I was wary of the fact that the AbstractMySqlPlatform might have been introduced with DBAL3 but it was not, and existed already)

@Pixelshaped Pixelshaped changed the title Fix casting issue due to MariaDB not included in inheritance schema anymore fix: casting issue due to MariaDB not included in inheritance schema anymore Oct 14, 2024
@Pixelshaped Pixelshaped changed the title fix: casting issue due to MariaDB not included in inheritance schema anymore fix: Casting issue due to MariaDB not included in inheritance schema anymore Oct 14, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (c5798aa) to head (a40a3e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2888   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files         167      167           
  Lines        8637     8637           
=======================================
  Hits         6808     6808           
  Misses       1829     1829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys
Copy link
Collaborator

phansys commented Oct 15, 2024

Thanks @Pixelshaped.

Could you please add the changelog entry for the fix?

@Pixelshaped
Copy link
Contributor Author

Not sure I did well but the entry is added!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Javier Spagnoletti <[email protected]>
@phansys phansys added Bug A confirmed bug in Extensions that needs fixing. and removed Needs Changelog note labels Oct 16, 2024
@phansys phansys merged commit ee63c20 into doctrine-extensions:main Oct 16, 2024
22 checks passed
@phansys
Copy link
Collaborator

phansys commented Oct 16, 2024

Thank you @Pixelshaped!

@Pixelshaped
Copy link
Contributor Author

Pixelshaped commented Oct 22, 2024

Is there any ETA/calendar for release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A confirmed bug in Extensions that needs fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TranslationWalker CAST fails for a string fieldMapping type on MariaDB
3 participants