Skip to content

Commit

Permalink
Revert "Add $buildDir parameter to warmUp method" (#798)
Browse files Browse the repository at this point in the history
* Revert "Add $buildDir parameter to warmUp method"

This reverts commit dc54819.

* Skip self-deprecations
  • Loading branch information
franmomu authored Dec 9, 2023
1 parent 8a31e71 commit 1c10e04
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CacheWarmer/HydratorCacheWarmer.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function isOptional()
}

/** @return string[] */
public function warmUp(string $cacheDir, ?string $buildDir = null)
public function warmUp(string $cacheDir)
{
// we need the directory no matter the hydrator cache generation strategy.
$hydratorCacheDir = (string) $this->container->getParameter('doctrine_mongodb.odm.hydrator_dir');
Expand Down
2 changes: 1 addition & 1 deletion CacheWarmer/PersistentCollectionCacheWarmer.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function isOptional()
}

/** @return string[] */
public function warmUp(string $cacheDir, ?string $buildDir = null)
public function warmUp(string $cacheDir)
{
// we need the directory no matter the hydrator cache generation strategy.
$collCacheDir = (string) $this->container->getParameter('doctrine_mongodb.odm.persistent_collection_dir');
Expand Down
2 changes: 1 addition & 1 deletion CacheWarmer/ProxyCacheWarmer.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function isOptional()
}

/** @return string[] */
public function warmUp(string $cacheDir, ?string $buildDir = null)
public function warmUp(string $cacheDir)
{
// we need the directory no matter the proxy cache generation strategy.
$proxyCacheDir = (string) $this->container->getParameter('doctrine_mongodb.odm.proxy_dir');
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<!-- <server name="DOCTRINE_MONGODB" value="/path/to/doctrine-mongodb/lib" /> -->
<!-- <server name="DOCTRINE_COMMON" value="/path/to/doctrine-common/lib" /> -->
<!-- Allow 1 direct deprecation until https://github.com/doctrine/DoctrineMongoDBBundle/pull/675 is merged -->
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=1"/>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=1&amp;max[self]=3"/>
</php>

<coverage>
Expand Down

0 comments on commit 1c10e04

Please sign in to comment.