[Encryption] Fix format of encryptedFieldsMaps in the autoEncryption configuration
#905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jul 4, 2025
| $encryptedFieldsMap = []; | ||
| foreach ($documentManager->getMetadataFactory()->getAllMetadata() as $metadata) { | ||
| $database = $documentManager->getDocumentDatabase($metadata->getName()); | ||
| $collectionInfoIterator = $database->listCollections(['filter' => ['name' => $metadata->getCollection()]]); |
There was a problem hiding this comment.
This is inspired by the get_encrypted_fields_from_server function.
GromNaN
commented
Jul 7, 2025
alcaeus
reviewed
Jul 7, 2025
There was a problem hiding this comment.
I think this change is reasonable. We need to make sure how to properly generate the encryptedFieldsMap for use in the configuration. For a future improvement, we can consider dumping the encryptedFieldsMap based on the return value of createEncryptedCollection calls in the schema:create command.
GromNaN
force-pushed
the
encryptedFieldsMap
branch
from
125545d to
96849e3
Compare
GromNaN
commented
Jul 10, 2025
| <doctrine:queries queryType="equality" /> | ||
| </doctrine:field> | ||
| </doctrine:encryptedFields> | ||
| <
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In driver options, the
encryptedFieldsMapoption must:fieldskey with the list of fieldsquery.minandquery.maxto the same BSON type as the fieldkeyId. But this value will change every time the database is reset.This needs to be improved by leveraging
keyAltNames.