Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of unique node type in support of real outer joins #226

Merged
merged 2 commits into from
Nov 6, 2015

Conversation

sarcher
Copy link
Contributor

@sarcher sarcher commented Nov 2, 2015

This is a companion to doctrine/phpcr-odm#667 which introduces the designation of documents using unique node types at the mapping level in order to support real outer joins in Jackrabbit. This PR introduces a shell command and hooks the verification into the cache warming process.

@sarcher
Copy link
Contributor Author

sarcher commented Nov 2, 2015

Oh, and worth noting that this will fail Travis until doctrine/phpcr-odm#667 is merged, and that is expected.

@lsmith77 lsmith77 added review and removed wip/poc labels Nov 2, 2015
@lsmith77 lsmith77 added this to the 1.3 milestone Nov 4, 2015
@dbu
Copy link
Member

dbu commented Nov 6, 2015

deprecation notes will be handled in #231

dbu added a commit that referenced this pull request Nov 6, 2015
Verification of unique node type in support of real outer joins
@dbu dbu merged commit de7182c into doctrine:master Nov 6, 2015
@lsmith77 lsmith77 removed the review label Nov 6, 2015
@dbu
Copy link
Member

dbu commented Nov 6, 2015

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants