Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Do not call non-static method as static method #245

Merged
merged 2 commits into from
Dec 15, 2015

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Dec 12, 2015

Static was removed from this method in 1.3: doctrine/phpcr-odm#667 (not sure why though) This now errors when warming up the cache.

@@ -62,8 +62,10 @@ public function isOptional()
*/
public function warmUp($cacheDir)
{
$helper = new UniqueNodeTypeHelper();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seems to be trailing whitespace here, styleci is unhappy with this line.

@dbu
Copy link
Member

dbu commented Dec 14, 2015

hm , but the PR you link is adding that class. did we maybe not sync the PR on the bundle with the latest version of the lib PR?

the reasoning is that static methods make it hard to customize things. instantiating locally is not helping much either, but at least the road to making it more flexible is open with this pattern.

@dbu
Copy link
Member

dbu commented Dec 14, 2015

so indeed, they went out of sync and we seem to not have a test for the cache warmer. can you please fix the CS issue @wouterj ?

@wouterj
Copy link
Contributor Author

wouterj commented Dec 14, 2015

done

dbu added a commit that referenced this pull request Dec 15, 2015
[Bugfix] Do not call non-static method as static method
@dbu dbu merged commit 06da7ec into doctrine:master Dec 15, 2015
@lsmith77 lsmith77 removed the review label Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants