Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate schema management tests #6865

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 22, 2025

Removed more schema management integration tests:

  1. NewPrimaryKeyWithNewAutoIncrementColumnTest duplicates AlterTableTest#testAddPrimaryKeyOnNewAutoIncrementColumn() but runs only on MySQL
  2. DBAL168Test doesn't fail if the code change it covers is reverted, although other tests do
  3. DBAL510Test doesn't cover any specific requirement

The code coverage is reported as slightly dropped but it looks like a false positive:

Commits have different number of coverage report uploads

The no longer covered lines are unrelated to the tests being removed and must still be covered by other tests.

1. NewPrimaryKeyWithNewAutoIncrementColumnTest duplicates
   AlterTableTest#testAddPrimaryKeyOnNewAutoIncrementColumn()
2. DBAL168Test doesn't fail if the code change it covers is reverted,
   although other tests do
3. DBAL510Test doesn't cover any specific requirement
@morozov morozov merged commit bb49ca4 into doctrine:4.2.x Mar 22, 2025
66 checks passed
@morozov morozov deleted the remove-duplicate-tests branch March 22, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants